[FEATURE] Add TYPO3 v14 support - #17
Open
bmack wants to merge 1 commit into
Open
Conversation
Two of the core APIs used here were already removed or made inaccessible in v13, so the declared v13 support never actually worked: * PageRepository::DOKTYPE_RECYCLER was removed in v13.0. The value 255 is kept as a literal, so v12 installations keep skipping those pages. * RootlineUtility::getCacheIdentifier() is protected since v13.1 and is therefore no longer part of the debug log message. Page and language uids are now cast to int before they are passed to the strictly typed core APIs, since the database returns them as strings on some platforms. A failing page no longer aborts the whole run, it is reported and skipped instead. The auth service registration in ext_localconf.php is dropped: its "getGroupsFE" subtype was removed in v11, and the class is already wired as a listener for ModifyResolvedFrontendGroupsEvent. Supported versions are now v12 LTS, v13 LTS and v14 LTS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the extension work on TYPO3 v14 LTS, while keeping v12 LTS and v13 LTS support.
Every API touched here was verified against real 12.4, 13.4 and 14.3 checkouts.
Actual breakage
Two of these were already broken on v13, even though
^13.4was declared:PageRepository::DOKTYPE_RECYCLERwas removed in v13.0 (#101137) —Error: Undefined constanton the first statement ofPageWarmupService::warmUp(). The literal255is kept in the exclude list so v12 installations keep skipping those pages; on v13+ they were migrated toDOKTYPE_BE_USER_SECTION, which is excluded anyway.RootlineUtility::getCacheIdentifier()becameprotectedin v13.1 —Error: Call to protected method. It was only used for a debug log message, and there is no public replacement, so it is gone from the log.intparameters inSiteFinder::getSiteByPageId(),RootlineUtility::__construct()andLanguageAspect—fetchAssociative()returns strings on some platforms and the calling files declarestrict_types=1, so this threw aTypeError. Uids are now cast.Cleanup
ext_localconf.phpis removed. It registered the class as an auth service with subtypegetGroupsFE, which core dropped in v11 (#93108) in favour ofModifyResolvedFrontendGroupsEvent— the event this class already listens to. Dead code since v11.\InvalidArgumentExceptionout ofgetLanguageById(), which would kill a 50k page warmup; failures are now reported per page and skipped.WarmupServiceInterfacereplaces thecall_user_func_array()dispatch, and an unknowntypeargument returnsCommand::INVALIDinstead of silently doing nothing.README.mddocumentedcache:warmup; the command is registered ascache:warmupPages.Version constraints
^12.4 || ^13.4 || ^14.0, PHP^8.1.ext_emconf.phpis12.4.0-14.3.99— 14.3 is the v14 LTS.Version is bumped to 3.0.0 because
RootlineWarmupService::__construct()gained aContextargument andext_localconf.phpis gone. Nothing changes for ordinary users.Testing
Static only: lint, plus API existence and signature comparison across all three LTS trees. Not yet smoke-tested against a running v14 instance.